Editor edge drawing issues

Error message

Deprecated function: implode(): Passing glue string after array is deprecated. Swap the parameters in drupal_get_feeds() (line 394 of /var/www/pied-piper.ermarian.net/includes/common.inc).
AuthorTopic: Editor edge drawing issues
Niemand
Infiltrator
Member # 5576
 written Friday, October 19 2007 19:13 Profile Homepage #0
quote:
Originally written by Dahak:
If the designer replaces the graphics for floors 11-22 or 45-56 then the code that handles drawing the edges for cave/stone or grass/dirt instead defaults to 18 (for 11-22) and 52(for 45-56) when ever you attempt to draw with dirt or any of its edges. So instead of a nice 3x3 square you instead get a 3x3 grid of corners.
So I said I would look into this and I did; I replaced the graphics for floors 45 to 56, and everything behaved exactly as it should. Dahak, what version of the editor were using, and how did you 'replace the graphics'? Can anyone else reproduce/shed light on this bug?

--------------------
Überraschung des Dosenöffners!
"On guard, you musty sofa!"
Posts: 627 | Registered: Monday, March 7 2005 08:00
Dahak
Infiltrator
Member # 148
 written Friday, October 19 2007 20:08 Profile #1
I just loaded the graphic into a sheet and this code to the data script.

// Dirt - Grass
begindefinefloor 45;
clear;
fl_name = "Dirt";
fl_which_sheet = 508;
fl_which_icon = 0;
fl_ed_which_sheet = 680;
fl_ed_which_icon = 25;
begindefinefloor 46;
clear;
fl_which_sheet = 508;
fl_ed_which_sheet = 680;
fl_which_icon = 1;
fl_ed_which_icon = 26;
begindefinefloor 47;
fl_which_icon = 2;
fl_ed_which_icon = 27;
begindefinefloor 48;
fl_which_icon = 3;
fl_ed_which_icon = 28;
begindefinefloor 49;
fl_which_icon = 4;
fl_ed_which_icon = 29;
begindefinefloor 50;
fl_which_icon = 5;
fl_ed_which_icon = 30;
begindefinefloor 51;
fl_which_icon = 6;
fl_ed_which_icon = 31;
begindefinefloor 52;
fl_which_icon = 7;
fl_ed_which_icon = 32;
begindefinefloor 53;
fl_which_icon = 8;
fl_ed_which_icon = 33;
begindefinefloor 54;
fl_which_icon = 9;
fl_ed_which_icon = 34;
begindefinefloor 55;
fl_which_icon = 10;
fl_ed_which_icon = 35;
begindefinefloor 56;
fl_which_icon = 11;
fl_ed_which_icon = 36;
Edit:
The versions are - Mac OS X, Editor 1.02b5 and v1.0.3. Both have this issue.

[ Friday, October 19, 2007 20:11: Message edited by: Dahak ]

--------------------
My ego is bigger than yours.
Posts: 480 | Registered: Thursday, October 11 2001 07:00
Niemand
Infiltrator
Member # 5576
 written Friday, October 19 2007 20:24 Profile Homepage #2
Somehow, the way you redfined the floor seems to have done it. I think you'll find that everything works if you do:
begindefinefloor 45;
fl_name = "Dirt";
fl_is_ground = 0;
fl_is_rough = 1;
fl_out_fight_town_used = 1017; //could be changed
fl_which_sheet = 508;
fl_which_icon = 0;
fl_ed_which_sheet = 680;
fl_ed_which_icon = 25;
begindefinefloor 46;
fl_which_icon = 1;
fl_ed_which_icon = 26;
begindefinefloor 47;
fl_which_icon = 2;
fl_ed_which_icon = 27;
begindefinefloor 48;
fl_which_icon = 3;
fl_ed_which_icon = 28;
begindefinefloor 49;
fl_which_icon = 4;
fl_ed_which_icon = 29;
begindefinefloor 50;
fl_which_icon = 5;
fl_ed_which_icon = 30;
begindefinefloor 51;
fl_which_icon = 6;
fl_ed_which_icon = 31;
begindefinefloor 52;
fl_which_icon = 7;
fl_ed_which_icon = 32;
begindefinefloor 53;
fl_which_icon = 8;
fl_ed_which_icon = 33;
begindefinefloor 54;
fl_which_icon = 9;
fl_ed_which_icon = 34;
begindefinefloor 55;
fl_which_icon = 10;
fl_ed_which_icon = 35;
begindefinefloor 56;
fl_which_icon = 11;
fl_ed_which_icon = 36;
I think that the 'ground' and 'rough' settings may be what the editor actually detects for edge drawing, or something.

--------------------
Überraschung des Dosenöffners!
"On guard, you musty sofa!"
Posts: 627 | Registered: Monday, March 7 2005 08:00
Dahak
Infiltrator
Member # 148
 written Friday, October 19 2007 20:34 Profile #3
Nope.

--------------------
My ego is bigger than yours.
Posts: 480 | Registered: Thursday, October 11 2001 07:00
Niemand
Infiltrator
Member # 5576
 written Friday, October 19 2007 20:39 Profile Homepage #4
You're quite sure? Because it fixes the issue for me on v1.0.3 of the editor.

--------------------
Überraschung des Dosenöffners!
"On guard, you musty sofa!"
Posts: 627 | Registered: Monday, March 7 2005 08:00
Dahak
Infiltrator
Member # 148
 written Friday, October 19 2007 20:49 Profile #5
I was going to prove you wrong by copying the whole code you posted instead of just the changes... But when I did that it worked. It just needs fl_is_rough = 1; to work.

But I had that the first time and it didn't work after I reopened the scenario...

Whatever, it works now.

Edit:
Nevermind the edit. It doesn't exist so there is nothing to see. Move along folks.

[ Friday, October 19, 2007 20:52: Message edited by: Dahak ]

--------------------
My ego is bigger than yours.
Posts: 480 | Registered: Thursday, October 11 2001 07:00